Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 cleanup #16039

Merged
merged 49 commits into from
Jan 4, 2025
Merged

S3 cleanup #16039

merged 49 commits into from
Jan 4, 2025

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

@cirospaciari can you finish this

How did you verify your code works?

@robobun
Copy link

robobun commented Dec 29, 2024 •
edited
Loading

Updated 7:43 PM PT - Jan 3rd, 2025

❌ @cirospaciari, your commit e9df364 has 2 failures in #8925:

🧪   try this PR locally:

bunx bun-pr 16039

@cirospaciari cirospaciari marked this pull request as ready for review January 3, 2025 06:57
Jarred-Sumner
Jarred-Sumner commented Jan 3, 2025
View reviewed changes
src/s3.zig Outdated Show resolved Hide resolved
Jarred-Sumner
Jarred-Sumner commented Jan 3, 2025
View reviewed changes
src/s3.zig Outdated Show resolved Hide resolved
Jarred-Sumner
Jarred-Sumner commented Jan 3, 2025
View reviewed changes
src/s3.zig Outdated Show resolved Hide resolved
@Jarred-Sumner Jarred-Sumner merged commit d5fc928 into main Jan 4, 2025
43 of 51 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/s3- branch January 4, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fendyzainol9 Fendyzainol9 Fendyzainol9 left review comments

@cirospaciari cirospaciari cirospaciari left review comments

Assignees

@cirospaciari cirospaciari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jarred-Sumner @robobun @cirospaciari @Fendyzainol9